/* Copyright 2022 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package aggregated import ( "net/http" "net/http/httptest" "io" "testing" "github.com/stretchr/testify/assert" genericfeatures "k8s.io/apiserver/pkg/features" utilfeature "k8s.io/apiserver/pkg/util/feature" featuregatetesting "k8s.io/component-base/featuregate/testing" ) const discoveryPath = "/apis" const jsonAccept = "application/json" const protobufAccept = "application/vnd.kubernetes.protobuf" const aggregatedAcceptSuffix = ";g=apidiscovery.k8s.io;v=v2beta1;as=APIGroupDiscoveryList" const aggregatedJSONAccept = jsonAccept + aggregatedAcceptSuffix const aggregatedProtoAccept = protobufAccept + aggregatedAcceptSuffix func fetchPath(handler http.Handler, path, accept string) string { w := httptest.NewRecorder() req := httptest.NewRequest("GET", discoveryPath, nil) // Ask for JSON response req.Header.Set("Accept", accept) handler.ServeHTTP(w, req) return string(w.Body.Bytes()) } type fakeHTTPHandler struct { data string } func (f fakeHTTPHandler) ServeHTTP(resp http.ResponseWriter, req *http.Request) { io.WriteString(resp, f.data) } func TestAggregationEnabled(t *testing.T) { defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, genericfeatures.AggregatedDiscoveryEndpoint, true)() unaggregated := fakeHTTPHandler{data: "unaggregated"} aggregated := fakeHTTPHandler{data: "aggregated"} wrapped := WrapAggregatedDiscoveryToHandler(unaggregated, aggregated) testCases := []struct { accept string expected string }{ { // Misconstructed/incorrect accept headers should be passed to the unaggregated handler to return an error accept: "application/json;foo=bar", expected: "unaggregated", }, { // Empty accept headers are valid and should be handled by the unaggregated handler accept: "", expected: "unaggregated", }, { accept: aggregatedJSONAccept, expected: "aggregated", }, { accept: aggregatedProtoAccept, expected: "aggregated", }, { accept: jsonAccept, expected: "unaggregated", }, { accept: protobufAccept, expected: "unaggregated", }, { // Server should return the first accepted type accept: aggregatedJSONAccept + "," + jsonAccept, expected: "aggregated", }, { // Server should return the first accepted type accept: aggregatedProtoAccept + "," + protobufAccept, expected: "aggregated", }, } for _, tc := range testCases { body := fetchPath(wrapped, discoveryPath, tc.accept) assert.Equal(t, tc.expected, body) } } func TestAggregationDisabled(t *testing.T) { defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, genericfeatures.AggregatedDiscoveryEndpoint, false)() unaggregated := fakeHTTPHandler{data: "unaggregated"} aggregated := fakeHTTPHandler{data: "aggregated"} wrapped := WrapAggregatedDiscoveryToHandler(unaggregated, aggregated) testCases := []struct { accept string expected string }{ { // Misconstructed/incorrect accept headers should be passed to the unaggregated handler to return an error accept: "application/json;foo=bar", expected: "unaggregated", }, { // Empty accept headers are valid and should be handled by the unaggregated handler accept: "", expected: "unaggregated", }, { accept: aggregatedJSONAccept, expected: "unaggregated", }, { accept: aggregatedProtoAccept, expected: "unaggregated", }, { accept: jsonAccept, expected: "unaggregated", }, { accept: protobufAccept, expected: "unaggregated", }, { // Server should return the first accepted type. // If aggregation is disabled, the unaggregated type should be returned. accept: aggregatedJSONAccept + "," + jsonAccept, expected: "unaggregated", }, { // Server should return the first accepted type. // If aggregation is disabled, the unaggregated type should be returned. accept: aggregatedProtoAccept + "," + protobufAccept, expected: "unaggregated", }, } for _, tc := range testCases { body := fetchPath(wrapped, discoveryPath, tc.accept) assert.Equal(t, tc.expected, body) } }